[PATCH] D74944: [LoopVectorize] Fix cost for calls to functions that have vector versions

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 24 07:54:07 PST 2020


nemanjai marked an inline comment as done.
nemanjai added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:3292
+
+  if (!TLI || CI->isNoBuiltin() || !VecFunc)
     return Cost;
----------------
fpetrogalli wrote:
> Nit: I just noticed that also the `!TLI` condition can probably be removed?
Can you please justify? I think the idea is that if we didn't have a TLI object, we would end up with `nullptr` from `getVectorizedFunction()` but want to make sure.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74944/new/

https://reviews.llvm.org/D74944





More information about the llvm-commits mailing list