[PATCH] D75029: [DWARFLinker][NFC] Remove usages of "const object::ObjectFile" from DWARFLinker.

Alexey Lapshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 23 23:01:25 PST 2020


avl created this revision.
avl added reviewers: JDevlieghere, friss, dblaikie, aprantl.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.
avl added a project: debug-info.

DWARFContext has all the required information to access source debug info.
It is not necessary to use "const object::ObjectFile" to create DWARFContext.
Thus this patch removes all usages of "const object::ObjectFile"
from DWARFLinker. Instead, already created DWARFContext is passed
to DWARFLinker. The purpose is to not depend on "const object::ObjectFile".

The patch looks big, but most of changes are renamings and movements.

Testing: it passes "check-all" lit testing. MD5 checksum for clang .dSYM bundle
matches for the dsymutil with/without that patch.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D75029

Files:
  llvm/include/llvm/DWARFLinker/DWARFLinker.h
  llvm/lib/DWARFLinker/DWARFLinker.cpp
  llvm/tools/dsymutil/DwarfLinkerForBinary.cpp
  llvm/tools/dsymutil/DwarfLinkerForBinary.h
  llvm/tools/dsymutil/DwarfStreamer.cpp
  llvm/tools/dsymutil/DwarfStreamer.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75029.246142.patch
Type: text/x-patch
Size: 41708 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200224/3f448654/attachment.bin>


More information about the llvm-commits mailing list