[PATCH] D74708: [MLIR][Ploops] Add custom builders from ParallelOp and ReduceOp.

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache added inline comments.


================
Comment at: mlir/lib/Dialect/LoopOps/LoopOps.cpp:239
 
+void ParallelOp::build(Builder *builder, OperationState &result, ValueRange lbs,
+                       ValueRange ubs, ValueRange steps,
----------------
I don't think this code path is tested?


================
Comment at: mlir/lib/Dialect/LoopOps/LoopOps.cpp:364
 
+void ReduceOp::build(Builder *builder, OperationState &result, Value operand) {
+  auto type = operand.getType();
----------------
I don't think this code path is tested?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74708/new/

https://reviews.llvm.org/D74708