[PATCH] D74532: [mlir] Linalg: Extend promotion to non f32 buffers.

Nicolas Vasilache via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 23 18:48:46 PST 2020


nicolasvasilache added a comment.

> I wonder how much of the test here is just carried over mechanically and if we could do something to reduce this churn...

The check part can be significantly reduced, one only really needs to check the allocs.
Re. test itself, this is just a tiled `linalg.matmul`, we could leave the original one unchanged and for the new ones just write a 1-liner test for f16/f64/i32/whatever and do `mlir-opt --linalg-tile ... | mlir-opt -linalg-promote-subviews | FileCheck %s --check=prefix=NEW_PREFIX`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74532/new/

https://reviews.llvm.org/D74532





More information about the llvm-commits mailing list