[PATCH] D75024: [SCCIterator] Check if a SCC is a natural loop.

Stefanos Baziotis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 23 11:36:28 PST 2020


baziotis added a comment.

First of all, do you think this is a useful addition to the SCC interface? We recently needed it in a patch.

Second, I currently don't know how to get `LoopInfo`. There's also a problem that it is not sure that we'll be able
to get `LoopInfo` and in that case, what do we return ? (i.e. with this interface there's no way to signify an error).

Third, do you think there's a better way ? I was thinking that maybe there was a
more straightforward way by trying to verify whether the criteria for a natural
loop are satisfied (i.e. there's a block that dominates all the other
blocks).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75024/new/

https://reviews.llvm.org/D75024





More information about the llvm-commits mailing list