[PATCH] D71663: [Coroutines] CoroElide enhancement

Sun Feb 23 07:45:57 PST 2020

modocache accepted this revision.
modocache added a comment.
This revision is now accepted and ready to land.

Sorry this review took so long, and thank you for addressing the regression I introduced in D43242 <https://reviews.llvm.org/D43242>!

This patch no longer cleanly applies due to my changes in D71900 <https://reviews.llvm.org/D71900>, but I believe I was able to rebase it correctly in P8200 <https://reviews.llvm.org/P8200>. Based on that I think this looks like a great improvement, thank you!

Do you have commit access now, or would you like me to commit this (once you've updated it to apply cleanly) on your behalf?

================
Comment at: llvm/lib/Transforms/Coroutines/CoroElide.cpp:163
+  // Consider final coro.suspend as real terminator when current function
+  // is courutine expanded function.
+  if (CoroFinalSuspend) {
----------------
typo: "coroutine". Also, nit-pick comment, but: I would write this "Consider the final coro.suspend as the real terminator when the current function is a coroutine." But I might be misunderstanding what you mean by "real terminator" and "coroutine expanded function" here.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71663/new/

https://reviews.llvm.org/D71663