[PATCH] D74755: [llvm-objcopy] Attribute an empty section to a segment ending at its address

[Fangrui Song via Phabricator via llvm-commits]

MaskRay marked an inline comment as done.
MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/ELF/Object.cpp:1322
+
+  for (SectionBase &Sec : Obj.sections()) {
+    Segment *Seg = Sec.ParentSegment;
----------------
MaskRay wrote:
> I believe this code captures the intention of the original code. Though, no tests break with this change.
> 
> I find it difficult to construct a test case that will break by deleting this piece of code.
> 
> @jhenderson It seems you may have such tests?
Deleted. I think this is not useful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74755/new/

https://reviews.llvm.org/D74755