[PATCH] D74506: [SystemZ] Support the kernel backchain

[Ulrich Weigand via Phabricator via llvm-commits]

uweigand added inline comments.


================
Comment at: llvm/lib/Target/SystemZ/SystemZISelLowering.cpp:1478
+        unsigned Offset = TFL->getRegSpillOffset(MF, SystemZ::ArgFPRs[I]);
         int FI = MFI.CreateFixedObject(8, RegSaveOffset + Offset, true);
         SDValue FIN = DAG.getFrameIndex(FI, getPointerTy(DAG.getDataLayout()));
----------------
jonpa wrote:
> uweigand wrote:
> > I believe this now needs to be -SystemZMC::CallFrameSize + Offset instead of RegSaveOffset + Offset.
> I think that should be equivalent due to the '!(IsVarArg && !SoftFloat)' check in getRegSpillOffset(). 
> 
> Would it be clearer to use -SystemZMC::CallFrameSize here still?
> 
> 
Yes, since if there were any offset, it would now be included in getRegSpillOffset ...  Right now, it seems like it would be added twice (since you're adding the output of two getRegSpillOffset calls).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74506/new/

https://reviews.llvm.org/D74506