[PATCH] D74938: [mlir][Tutorial] Add a section to Toy Ch.2 detailing the custom assembly format.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: mlir/docs/Tutorials/Toy/Ch-2.md:671
+custom format in C++. After beautifying the format of a few of our operations we
+now get a much more readable:
+
----------------
ftynse wrote:
> mehdi_amini wrote:
> > Why not provide a custom syntax for all of them?
> I think it is valuable to demonstrate the C++ way as well. Partly because the declarative format does not (and probably cannot) support all use cases, and partly to showcase the effort that went into building the infrastructure.
> 
> Personally, I really dislike the educational materials that don't offer enough explanation on what is going behind the nice and magic-feeling solution.
The C and C++ are shown above? Not sure if we're talking about the same thing, I was referring to the fact that the IR snippet below was a mix of generic printer and custom printer (so some operation were missing their custom printer/parser) and the mix was a bit ugly / confusing to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74938/new/

https://reviews.llvm.org/D74938