[PATCH] D73999: [MC][ELF] Error for sh_type, sh_flags or sh_entsize change

Fri Feb 21 18:53:54 PST 2020

MaskRay added a comment.

In D73999#1887836 <https://reviews.llvm.org/D73999#1887836>, @stella.stamenova wrote:

> In D73999#1887784 <https://reviews.llvm.org/D73999#1887784>, @MaskRay wrote:
>
> > In D73999#1887767 <https://reviews.llvm.org/D73999#1887767>, @stella.stamenova wrote:
> >
> > > Looks like this broke the Windows LLDB bot:
> > >
> > > http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/14056
> >
> >
> > The tests used wrong sh_flags caught by this assembler change.
> >
> > Hopefully fixed by ebee131259719fa9c06cd346e21ace3fa8ac0888 <https://reviews.llvm.org/rGebee131259719fa9c06cd346e21ace3fa8ac0888>. I made a typo in my description. sh_flags was incorrect, not sh_type.
>
>
> Thanks! It looks like one of them is still broken though :(

Fixed by e29065a105342a904871437d18a4e6fab09e5bc1 <https://reviews.llvm.org/rGe29065a105342a904871437d18a4e6fab09e5bc1>.

Sorry for the churn.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73999/new/

https://reviews.llvm.org/D73999