[PATCH] D68006: DSE miscompile when store is clobbered across loop iterations

Artur Pilipenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 21 16:30:15 PST 2020


apilipenko updated this revision to Diff 246040.
apilipenko added a comment.

I rework the patch using PHITransAddr. Now instead of tracking the backedge flag I keep track of the address to check and translate the address when needed.

This change should resolve the concern about overly conservative handling of load-store case, when the address dominates all the operations between load and store. Using PHITransAddr we would only do the translation if it's actually needed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68006/new/

https://reviews.llvm.org/D68006

Files:
  llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp
  llvm/test/Transforms/DeadStoreElimination/simple.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68006.246040.patch
Type: text/x-patch
Size: 13764 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200222/26efab20/attachment.bin>


More information about the llvm-commits mailing list