[PATCH] D74893: [mlir] Intrinsics generator: use TableGen-defined builder function

[Marcello Maggioni via Phabricator via llvm-commits]

kariddi added inline comments.


================
Comment at: mlir/include/mlir/Dialect/LLVMIR/LLVMOpBase.td:149
+    : LLVM_IntrOpBase<LLVM_Dialect, "intr." # mnem, !subst(".", "_", mnem),
+                      overloadedResults, overloadedOperands, traits, hasResult>;
+
----------------
kariddi wrote:
> What is the story to convert MLIR operations with multiple return values into intrinsics returning multiple values (structures)?
If everything would pan out just fine for multiple results I suggest renaming "hasResult" with "hasResults"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74893/new/

https://reviews.llvm.org/D74893