[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 21 16:02:33 PST 2020


jdoerfert marked an inline comment as done.
jdoerfert added inline comments.


================
Comment at: clang/test/OpenMP/begin-declare-variant_elided_range_withouth_end.c:5
+// TODO: Improve the error message
+#pragma omp begin declare variant match(device={kind(cpu)}) // expected-error {{unterminated '#pragma clang attribute push' at end of file}}
+// The matching end is missing. Since the device clause is matching we will
----------------
The errors referring to `clang attribute` will be removed from this review again. Accidentally included a SEMA work-in-progress state here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74941/new/

https://reviews.llvm.org/D74941





More information about the llvm-commits mailing list