[PATCH] D74883: Add a llvm-gsymutil tool that can convert object files to GSYM and perform lookups.

[Greg Clayton via Phabricator via llvm-commits]

clayborg added a comment.

In D74883#1886440 <https://reviews.llvm.org/D74883#1886440>, @labath wrote:

> In D74883#1884801 <https://reviews.llvm.org/D74883#1884801>, @clayborg wrote:
>
> > > I do not feel qualified to review gsym stuff, but I do think that the DataExtractor changes should go in a separate patch.
> >
> > I thought I remembered someone saying they didn't want dead code being checked in on its own. But I can split this out if needed.
>
>
> I'm not sure what was the context of that discussion, but that seem odd. Just this week, I was asked to do a similar split too (and my patch was much smaller than this one). Either way, I think that in this particular case, any concerns like that can be resolved by just linking DataExtractor patch to the patch which adds code for using it.


That was a long time ago when I tried to check something into DataExtractor on its own. I am fine to split this up. It has a unit test, so it isn't actually dead code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74883/new/

https://reviews.llvm.org/D74883