[llvm] 0ad6fc9 - [SelectionDAG] remove unused isFast() helper function; NFC

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 21 13:58:17 PST 2020


Author: Sanjay Patel
Date: 2020-02-21T16:58:10-05:00
New Revision: 0ad6fc9928d8a5e3bd148a112d6e772248e515ae

URL: https://github.com/llvm/llvm-project/commit/0ad6fc9928d8a5e3bd148a112d6e772248e515ae
DIFF: https://github.com/llvm/llvm-project/commit/0ad6fc9928d8a5e3bd148a112d6e772248e515ae.diff

LOG: [SelectionDAG] remove unused isFast() helper function; NFC

We want flag users to check individual fast-math flags,
not that all of them are set. This was also probably
not working as intended because NoFPExcept isn't always
set on non-strict nodes.

Added: 
    

Modified: 
    llvm/include/llvm/CodeGen/SelectionDAGNodes.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/CodeGen/SelectionDAGNodes.h b/llvm/include/llvm/CodeGen/SelectionDAGNodes.h
index 840e3d0baa2e..086a54c0b078 100644
--- a/llvm/include/llvm/CodeGen/SelectionDAGNodes.h
+++ b/llvm/include/llvm/CodeGen/SelectionDAGNodes.h
@@ -469,11 +469,6 @@ struct SDNodeFlags {
   bool hasAllowReassociation() const { return AllowReassociation; }
   bool hasNoFPExcept() const { return NoFPExcept; }
 
-  bool isFast() const {
-    return NoSignedZeros && AllowReciprocal && NoNaNs && NoInfs && NoFPExcept &&
-           AllowContract && ApproximateFuncs && AllowReassociation;
-  }
-
   /// Clear any flags in this flag set that aren't also set in Flags.
   /// If the given Flags are undefined then don't do anything.
   void intersectWith(const SDNodeFlags Flags) {
@@ -990,7 +985,6 @@ END_TWO_BYTE_PACK()
 
   const SDNodeFlags getFlags() const { return Flags; }
   void setFlags(SDNodeFlags NewFlags) { Flags = NewFlags; }
-  bool isFast() { return Flags.isFast(); }
 
   /// Clear any flags in this node that aren't also set in Flags.
   /// If Flags is not in a defined state then this has no effect.


        


More information about the llvm-commits mailing list