[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

[Kelvin Li via Phabricator via llvm-commits]

kkwli0 added inline comments.


================
Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1251
   "expected '#pragma omp end declare target'">;
+def err_expected_end_declare_target_or_variant : Error<
+  "expected '#pragma omp end declare %select{target|variant}0'">;
----------------
Can we merge it with err_expected_end_declare_target?


================
Comment at: clang/lib/Parse/ParseOpenMP.cpp:1790
+    ASTContext &ASTCtx = Actions.getASTContext();
+    TI.getAsVariantMatchInfo(ASTCtx, VMI, /* DeviseSetOnly */ true);
+    OMPContext OMPCtx(ASTCtx.getLangOpts().OpenMPIsDevice,
----------------
DeviseSetOnly -> DeviceSetOnly


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74941/new/

https://reviews.llvm.org/D74941