[PATCH] D73226: [ms] [llvm-ml] Improve data support, adding names and complex initializers.

[Nico Weber via Phabricator via llvm-commits]

thakis accepted this revision.
thakis added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/MC/MCParser/MasmParser.cpp:3018
+      for (int i = 0; i < Repetitions; ++i)
+        ValuesAsInt.append(DuplicatedValues.begin(), DuplicatedValues.end());
+    } else {
----------------
Is there no more efficient way to express this internally? If you `1000000 dup (2)`, do we have to write out 1M 2s?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73226/new/

https://reviews.llvm.org/D73226