[llvm] c90ea87 - [X86] Fix SDLoc initialization

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 21 09:29:47 PST 2020


Thanks! Which compiler caught it?
~Craig


On Fri, Feb 21, 2020 at 9:26 AM Nikita Popov via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

>
> Author: Nikita Popov
> Date: 2020-02-21T18:26:05+01:00
> New Revision: c90ea87cfd71f8da05f2e684d3cf139f9773c15d
>
> URL:
> https://github.com/llvm/llvm-project/commit/c90ea87cfd71f8da05f2e684d3cf139f9773c15d
> DIFF:
> https://github.com/llvm/llvm-project/commit/c90ea87cfd71f8da05f2e684d3cf139f9773c15d.diff
>
> LOG: [X86] Fix SDLoc initialization
>
> Fixes -Wparentheses warning, in this case indicating a genuine
> bug.
>
> Added:
>
>
> Modified:
>     llvm/lib/Target/X86/X86ISelLowering.cpp
>
> Removed:
>
>
>
>
> ################################################################################
> diff  --git a/llvm/lib/Target/X86/X86ISelLowering.cpp
> b/llvm/lib/Target/X86/X86ISelLowering.cpp
> index 7f6d36de7150..64cae53b0d40 100644
> --- a/llvm/lib/Target/X86/X86ISelLowering.cpp
> +++ b/llvm/lib/Target/X86/X86ISelLowering.cpp
> @@ -28740,7 +28740,7 @@ SDValue X86TargetLowering::LowerF128Call(SDValue
> Op, SelectionDAG &DAG,
>
>  // Custom split CVTPS2PH with wide types.
>  static SDValue LowerCVTPS2PH(SDValue Op, SelectionDAG &DAG) {
> -  SDLoc(dl);
> +  SDLoc dl(Op);
>    EVT VT = Op.getValueType();
>    SDValue Lo, Hi;
>    std::tie(Lo, Hi) = DAG.SplitVectorOperand(Op.getNode(), 0);
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200221/a5703e09/attachment.html>


More information about the llvm-commits mailing list