[PATCH] D72885: Add Query API for llvm.assume holding attributes

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 21 09:09:39 PST 2020


nikic added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/KnowledgeRetention.cpp:232
+  if (IsOn) {
+    if (Lookup->End - Lookup->Begin < BOIE_WasOn)
+      return false;
----------------
This causes a warning:

```
warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
```

Can you please check whether this condition can be simply dropped, or some other change is needed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72885/new/

https://reviews.llvm.org/D72885





More information about the llvm-commits mailing list