[PATCH] D74945: AMDGPU/GlobalISel: Fix xnor matching

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 21 08:41:53 PST 2020


foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-and.mir:152
     ; WAVE64: [[COPY1:%[0-9]+]]:sreg_32 = COPY $sgpr1
-    ; WAVE64: [[S_AND_B32_:%[0-9]+]]:sreg_32 = S_AND_B32 [[COPY]], [[COPY1]], implicit-def dead $scc
+    ; WAVE64: [[S_AND_B32_:%[0-9]+]]:sreg_32 = S_AND_B32 [[COPY]], [[COPY1]], implicit-def $scc
     ; WAVE64: S_ENDPGM 0, implicit [[S_AND_B32_]]
----------------
Any particular reason we lose the "dead" here? Does it matter?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74945/new/

https://reviews.llvm.org/D74945





More information about the llvm-commits mailing list