[PATCH] D74965: [AArch64][SVE] Add +fullfp16 to sve-vector-splat.ll

Cameron McInally via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 21 07:37:16 PST 2020


cameron.mcinally created this revision.
cameron.mcinally added reviewers: efriedma, sdesmalen, huntergr.
Herald added subscribers: llvm-commits, psnobl, rkruppe, kristof.beyls, tschuett.
Herald added a reviewer: rengolin.
Herald added a project: LLVM.

Add +fullfp16 to sve-vector-splat.ll so we can test folding of immediates into moves.

This attribute can go away later when SVE has a full set of fp16 patterns in place.


https://reviews.llvm.org/D74965

Files:
  llvm/test/CodeGen/AArch64/sve-vector-splat.ll


Index: llvm/test/CodeGen/AArch64/sve-vector-splat.ll
===================================================================
--- llvm/test/CodeGen/AArch64/sve-vector-splat.ll
+++ llvm/test/CodeGen/AArch64/sve-vector-splat.ll
@@ -1,4 +1,4 @@
-; RUN: llc -mtriple=aarch64-linux-gnu -mattr=+sve < %s | FileCheck %s
+; RUN: llc -mtriple=aarch64-linux-gnu -mattr=+sve,+fullfp16  < %s | FileCheck %s
 
 ;; Splats of legal integer vector types
 
@@ -190,26 +190,23 @@
   ret <vscale x 2 x double> %2
 }
 
-; TODO: The f16 constant should be folded into the move.
 define <vscale x 8 x half> @splat_nxv8f16_zero() {
 ; CHECK-LABEL: splat_nxv8f16_zero:
-; CHECK: mov z0.h, h0
+; CHECK: mov z0.h, #0
 ; CHECK-NEXT: ret
   ret <vscale x 8 x half> zeroinitializer
 }
 
-; TODO: The f16 constant should be folded into the move.
 define <vscale x 4 x half> @splat_nxv4f16_zero() {
 ; CHECK-LABEL: splat_nxv4f16_zero:
-; CHECK: mov z0.h, h0
+; CHECK: mov z0.h, #0
 ; CHECK-NEXT: ret
   ret <vscale x 4 x half> zeroinitializer
 }
 
-; TODO: The f16 constant should be folded into the move.
 define <vscale x 2 x half> @splat_nxv2f16_zero() {
 ; CHECK-LABEL: splat_nxv2f16_zero:
-; CHECK: mov z0.h, h0
+; CHECK: mov z0.h, #0
 ; CHECK-NEXT: ret
   ret <vscale x 2 x half> zeroinitializer
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74965.245854.patch
Type: text/x-patch
Size: 1269 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200221/132efc24/attachment.bin>


More information about the llvm-commits mailing list