[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added a comment.

Will tests come in a later patch?



================
Comment at: clang/include/clang/AST/OpenMPClause.h:6700
   /// independent of clang. Thus, expressions and conditions are evaluated in
-  /// this method.
+  /// this method. If \p DeviceSetOnly is set only the device selector set, if
+  /// present, is put into \p VMI.
----------------
only the -> only on the ?


================
Comment at: clang/lib/Parse/ParseOpenMP.cpp:1807
+        --Nesting;
+      if (DK == OMPD_begin_declare_variant)
+        ++Nesting;
----------------
Can there be an else here? Or is this the recommended style?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74941/new/

https://reviews.llvm.org/D74941