[llvm] df74033 - [WebAssembly] Remove unneeded getWasmKindForNamedSection function

Sam Clegg via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 20 22:51:43 PST 2020


Author: Sam Clegg
Date: 2020-02-20T22:49:08-08:00
New Revision: df74033ec9fceb0c7c1c44a61f240c05c4d5b368

URL: https://github.com/llvm/llvm-project/commit/df74033ec9fceb0c7c1c44a61f240c05c4d5b368
DIFF: https://github.com/llvm/llvm-project/commit/df74033ec9fceb0c7c1c44a61f240c05c4d5b368.diff

LOG: [WebAssembly] Remove unneeded getWasmKindForNamedSection function

I believe this was carried over from getELFKindForNamedSection since
the wasm backend originally used ELF object writing as a template.

Differential Revision: https://reviews.llvm.org/D74565

Added: 
    

Modified: 
    llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp b/llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
index 1a46691db6da..c2896f0d6767 100644
--- a/llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
+++ b/llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
@@ -1691,16 +1691,6 @@ static const Comdat *getWasmComdat(const GlobalValue *GV) {
   return C;
 }
 
-static SectionKind getWasmKindForNamedSection(StringRef Name, SectionKind K) {
-  // If we're told we have function data, then use that.
-  if (K.isText())
-    return SectionKind::getText();
-
-  // Otherwise, ignore whatever section type the generic impl detected and use
-  // a plain data section.
-  return SectionKind::getData();
-}
-
 MCSection *TargetLoweringObjectFileWasm::getExplicitSectionGlobal(
     const GlobalObject *GO, SectionKind Kind, const TargetMachine &TM) const {
   // We don't support explict section names for functions in the wasm object
@@ -1711,8 +1701,6 @@ MCSection *TargetLoweringObjectFileWasm::getExplicitSectionGlobal(
 
   StringRef Name = GO->getSection();
 
-  Kind = getWasmKindForNamedSection(Name, Kind);
-
   StringRef Group = "";
   if (const Comdat *C = getWasmComdat(GO)) {
     Group = C->getName();


        


More information about the llvm-commits mailing list