[PATCH] D74783: [mlir][ODS] Add support for specifying the successors of an operation.

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.
Herald added a subscriber: bader.


================
Comment at: mlir/lib/TableGen/Operator.cpp:311
+  auto *successorsOp = dyn_cast<DefInit>(successorsDag->getOperator());
+  if (!successorsOp || successorsOp->getDef()->getName() != "successor") {
+    PrintFatalError(def.getLoc(),
----------------
jpienaar wrote:
> Where does/could 'successorsOp->getDef()->getName() != "successor"' happen?
I'm assuming this is intended to capture cases like : `let successors = (outs ...);` or `let successors = (regions ...);`. I followed suit with what the regions/results/etc. lists were verifying.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74783/new/

https://reviews.llvm.org/D74783