[PATCH] D74926: AMDGPU/GlobalISel: Fix constant bus violation with source modifiers

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 20 12:39:48 PST 2020


arsenm created this revision.
arsenm added reviewers: foad, nhaehnle, kerbowa, hsmhsm.
Herald added subscribers: hiraditya, t-tye, tpr, dstuttard, rovka, yaxunl, wdng, jvesely, kzhuravl.
Herald added a project: LLVM.

This looked through copies to find the source modifiers, which may
have been SGPR->VGPR copies added to avoid potential constant bus
violations. Re-insert a copy to a VGPR if this happens.


https://reviews.llvm.org/D74926

Files:
  llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
  llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.h
  llvm/test/CodeGen/AMDGPU/GlobalISel/constant-bus-restriction.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-fadd.s32.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-fadd.s64.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74926.245724.patch
Type: text/x-patch
Size: 14286 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200220/14e3f89b/attachment.bin>


More information about the llvm-commits mailing list