[PATCH] D74453: [LegalizeTypes][RISCV] Correctly sign-extend comparison for ATOMIC_CMP_XCHG

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 20 10:56:37 PST 2020


efriedma added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:1880
+  /// value to be extended (ZERO_EXTEND, SIGN_EXTEND, or ANY_EXTEND).
+  virtual ISD::NodeType getExtendForAtomicCmpSwapArg() const {
+    return ISD::ANY_EXTEND;
----------------
Please add an explanation for why this needs to be separate from getExtendForAtomicOps.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74453/new/

https://reviews.llvm.org/D74453





More information about the llvm-commits mailing list