[PATCH] D74876: [mlir] Refactor the structure of the 'verifyConstructionInvariants' methods.

[River Riddle via Phabricator via llvm-commits]

rriddle marked 2 inline comments as done.
rriddle added inline comments.
Herald added a subscriber: bader.


================
Comment at: mlir/include/mlir/IR/StorageUniquerSupport.h:28
+/// avoid the need to include Location.h.
+const AttributeStorage *generateUnknownStorageLocation(MLIRContext *ctx);
+
----------------
bondhugula wrote:
> Why is this returning an AttributeStorage pointer instead of a Location?
We can't return Location here because it would require having the full declaration visible. Given that Locations are actually attributes, that isn't possible. To get around that, we can pass around the impl storage instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74876/new/

https://reviews.llvm.org/D74876