[PATCH] D74876: [mlir] Refactor the structure of the 'verifyConstructionInvariants' methods.

Uday Bondhugula via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 20 02:42:25 PST 2020


bondhugula accepted this revision.
bondhugula added a comment.
This revision is now accepted and ready to land.

Looks good to me.



================
Comment at: mlir/include/mlir/IR/StorageUniquerSupport.h:28
+/// avoid the need to include Location.h.
+const AttributeStorage *generateUnknownStorageLocation(MLIRContext *ctx);
+
----------------
Why is this returning an AttributeStorage pointer instead of a Location?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74876/new/

https://reviews.llvm.org/D74876





More information about the llvm-commits mailing list