[PATCH] D74688: AMDGPU/GlobalISel: Support llvm.trap and llvm.debugtrap intrinsics

Wed Feb 19 22:00:26 PST 2020

hsmhsm updated this revision to Diff 245576.
hsmhsm added a comment.

Changes as per further review comments:

1. First, I would like to make sure that all the *necessary* foundational issues are handled before actually discussing the crux of some assertion failure, that we hit, if we do not assign a register class to a virtual live-in register of SGPR01.
2. So, I have taken care of all your previous review comments here, and  I have deliberately put assertions about physical registers where it is expected.
3. Let's ensure these changes are as per your satisfaction, before moving to next point of discussion. Please let me know if I need to take care any remaining issues here before actually discussing assertion failure related issues.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74688/new/

https://reviews.llvm.org/D74688

Files:
  llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
  llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.h
  llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.trap.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74688.245576.patch
Type: text/x-patch
Size: 11362 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200220/d2cf9fb4/attachment.bin>