[PATCH] D74875: [WebAssembly] Fix memory bug introduced in 52861809994c

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 19 15:08:15 PST 2020


This revision was not accepted when it landed; it landed in state "Needs Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rG16aabc86e0ab: [WebAssembly] Fix memory bug introduced in 52861809994c (authored by tlively).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74875/new/

https://reviews.llvm.org/D74875

Files:
  llvm/lib/Target/WebAssembly/WebAssemblyRegStackify.cpp


Index: llvm/lib/Target/WebAssembly/WebAssemblyRegStackify.cpp
===================================================================
--- llvm/lib/Target/WebAssembly/WebAssemblyRegStackify.cpp
+++ llvm/lib/Target/WebAssembly/WebAssemblyRegStackify.cpp
@@ -923,9 +923,9 @@
         // Stackifying a multivalue def may unlock in-place stackification of
         // subsequent defs. TODO: Handle the case where the consecutive uses are
         // not all in the same instruction.
-        auto *SubsequentDef = DefI->defs().begin();
+        auto *SubsequentDef = Insert->defs().begin();
         auto *SubsequentUse = &Use;
-        while (SubsequentDef != DefI->defs().end() &&
+        while (SubsequentDef != Insert->defs().end() &&
                SubsequentUse != Use.getParent()->uses().end()) {
           if (!SubsequentDef->isReg() || !SubsequentUse->isReg())
             break;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74875.245540.patch
Type: text/x-patch
Size: 884 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200219/69682ebc/attachment.bin>


More information about the llvm-commits mailing list