[PATCH] D74852: [mlir][Linalg] Allow specifiying zero-rank shaped type operands to linalg.indexed_generic ops.

Han-Chung Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 19 15:06:06 PST 2020


hanchung marked 2 inline comments as done.
hanchung added inline comments.


================
Comment at: mlir/test/Dialect/Linalg/loops.mlir:394
+{
+  linalg.indexed_generic #trait_broadcast %arg0, %arg1 {
+    ^bb(%i: index, %j: index, %a: f32, %b: f32) :
----------------
mravishankar wrote:
> You could simplify the test by just having the operands as i32 element types
Sounds good, let's use i32 types.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74852/new/

https://reviews.llvm.org/D74852





More information about the llvm-commits mailing list