[PATCH] D74691: [Attributor] add some pattern to containsCycle

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

In D74691#1883772 <https://reviews.llvm.org/D74691#1883772>, @omarahmed wrote:

> > Can we write some explicit tests and add them to the willreturn.ll file?
>
> will do that :)


Great. I think one reason we don't see anything is that `willreturn` is at the end of the function attribute list and our existing check lines are still matching correctly even if the end changed, e.g.

  ; CHECK: Function Attrs: argmemonly nofree norecurse nosync nounwind

matches

  Function Attrs: argmemonly nofree norecurse nosync nounwind willreturn

just fine.

[EDIT: that means we might be able to remove some `FIXME`s in `willreturn.ll` and add `willreturn` in the check line]



================
Comment at: llvm/test/Transforms/Attributor/read_write_returned_arguments_scc.ll:165
 ; CHECK: attributes #{{.*}} = { nosync nounwind }
+; CHECK: attributes #{{.*}} = { norecurse nosync nounwind willreturn }
 ; CHECK-NOT: attributes #
----------------
omarahmed wrote:
> I don't understand this checks here at the end and this line was the only error that exists from the default tests but i don't understand , I added it for asking about it :) 
The function attributes have changed so we see changes here. That is alright.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74691/new/

https://reviews.llvm.org/D74691