[PATCH] D74872: AMDGPU/GlobalISel: Avoid illegal vector exts for add/sub/mul

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 19 13:59:41 PST 2020


arsenm created this revision.
arsenm added reviewers: nhaehnle, kerbowa, foad.
Herald added subscribers: hiraditya, t-tye, tpr, dstuttard, rovka, yaxunl, wdng, jvesely, kzhuravl.
Herald added a project: LLVM.
arsenm added parent revisions: D74863: AMDGPU/GlobalISel: Fix SALU mapping for v2s16 min/max, D74854: AMDGPU/GlobalISel: Fix mishandling SGPR v2s16 add/sub/mul.

When expanding scalar packed operations, we should not introduce
illegal vector casts LegalizerHelper introduces. We're not in a
legalizer context, and there's no RegBankSelect apply or legalize
worklist.


https://reviews.llvm.org/D74872

Files:
  llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp
  llvm/test/CodeGen/AMDGPU/GlobalISel/add.v2i16.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/regbankselect-add.v2s16.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74872.245515.patch
Type: text/x-patch
Size: 18454 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200219/5f0ceb37/attachment.bin>


More information about the llvm-commits mailing list