[PATCH] D74544: [MLIR] Add naive fusion of parallel loops.

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 19 12:24:04 PST 2020


rriddle added inline comments.


================
Comment at: mlir/lib/Dialect/LoopOps/Transforms/ParallelLoopFusion.cpp:55
+
+// Checks if the parallel loops have mixed access to the same buffers. Returns
+// `true` if the first parallel loop writes to the same indices that the second
----------------
nit: Please use /// for top-level comments.


================
Comment at: mlir/lib/Dialect/LoopOps/Transforms/ParallelLoopFusion.cpp:161
+      for (ArrayRef<ParallelOp> ploops : ploop_chains) {
+        llvm::errs() << "poo size = " << ploops.size() << '\n';
+        for (int i = 0, e = ploops.size(); i + 1 < e; ++i)
----------------
Please remove the debugging here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74544/new/

https://reviews.llvm.org/D74544





More information about the llvm-commits mailing list