[PATCH] D74803: TableGen: Fix logic for default operands

Wed Feb 19 12:24:03 PST 2020

arsenm added a comment.

In D74803#1883340 <https://reviews.llvm.org/D74803#1883340>, @dsanders wrote:

> I haven't dug very deep into this but it makes sense to me to be reading the InstInfo and as Simon notes, they should be identical for the cases that already work. On that basis LGTM
>
> Could you add a small test case to the TableGen directory? We don't have much information about how default operands behave and a couple easy to find examples would help with that.
>
> You might need to do something similar for GlobalISel as there was a lot of guesswork in the implementation of default operands there.

I already fixed the handling in GlobalISelEmitter a while ago

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74803/new/

https://reviews.llvm.org/D74803