[PATCH] D74691: [Attributor] add some pattern to containsCycle

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

In D74691#1883013 <https://reviews.llvm.org/D74691#1883013>, @omarahmed wrote:

> [...]
>  as the code puts on this function willreturn attribute and in the file read_write_returned_arguments_scc.ll it doesn't contain willreturn attribute so it gives an error with filecheck


It should have. Your extension to `AAWillReturn` should generally result in more `willreturn` attributes being deduced. That is the point after all. We need to verify each change to the CHECK lines though. We should also write explicit tests for loops with and without upper trip count limits, assuming we don't have them already.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74691/new/

https://reviews.llvm.org/D74691