[PATCH] D74773: [LLD][Debuginfo][NFC] create DWARFContext only once for the same object file.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/InputFiles.cpp:271
+      [&](Error Err) {
+        error(getName() + ": " + toString(std::move(Err)), true);
+      },
----------------
avl wrote:
> grimar wrote:
> > Lets also see what other LLD people think, but it does not feel to me that LLD should get something like "recoverable error" concept.
> > We already have warnings to report something not critical, so why not just report a warning in this case?
> > 
> The reason for reporting this as error is to have matching output with default DebugInfoDWARF output. i.e. when DebugInfoDWARF used in other context it would report this as "error". It could look a bit inconsistent when the same problem would be reported as "warning" from LLD context. If that is not important - then we could report it as warning and do not introduce "recoverable error" concept.  
I recall @ruiu mentioned that we don't want "recoverable error", but I can't find the thread.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74773/new/

https://reviews.llvm.org/D74773