[PATCH] D74647: [mlir][ODS] Add a new trait `TypesMatchWith`

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 19 10:19:50 PST 2020


rriddle marked 2 inline comments as done.
rriddle added inline comments.


================
Comment at: mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp:1155
       verifyCtx.addSubst(value.name,
-                         formatv("this->getOperation()->getResult({0})", i));
+                         formatv("(*this->getODSResults({0}).begin())", i));
   }
----------------
jpienaar wrote:
> Would front() work here?
Not yet, I need to add more accessors to the indexed_range class.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74647/new/

https://reviews.llvm.org/D74647





More information about the llvm-commits mailing list