[PATCH] D74815: [AsmPrinter] Change alignment of .stack_sizes from 1 to PointerSize

Wed Feb 19 09:21:32 PST 2020

MaskRay abandoned this revision.
MaskRay added a comment.

In D74815#1882132 <https://reviews.llvm.org/D74815#1882132>, @grimar wrote:

> Seems the following comment https://bugs.llvm.org/show_bug.cgi?id=36717#c2 from @jhenderson was never answered.
>  Can you explain why it is a problem?

I was very late at my time when I was making the change. The size is encoded in uleb128, so............ the output section naturally contains unaligned entries. An alignment will be a bad idea.

A symbolic relocation referencing a local symbol is fine. If it references a global symbol, there could be problems like https://sourceware.org/bugzilla/show_bug.cgi?id=24896

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74815/new/

https://reviews.llvm.org/D74815