[PATCH] D74691: [Attributor] add some pattern to containsCycle

[Stefanos Baziotis via Phabricator via llvm-commits]

baziotis added a comment.

In D74691#1882660 <https://reviews.llvm.org/D74691#1882660>, @omarahmed wrote:

> > Caps on the name. Be sure to check the nearby code and use clang-format (it seems you have done so, just reminding).
>
> I thought the default clang-format do it as required , I realized now that it is different :) , will fix it


Yes, clang format needs a little time to get used to. It's good to have in mind that it tries to be as less intrusive as possible.



================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:2371
 // TODO: Replace with more efficent code
 static bool containsCycle(Function &F) {
+  bool noAnalysis = false;
----------------
omarahmed wrote:
> baziotis wrote:
> > I think you still need to pass `A`. Are you sure this compiles?
> ohhh sry tried something and forgot to make it back in this part :) 
No worries. Try to be sure that any diff you upload compiles and passes the test suite. :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74691/new/

https://reviews.llvm.org/D74691