[PATCH] D74777: [VFS][WIP] More consistent handling of hybrid paths of Windows+Posix styles

John Brawn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 19 06:51:11 PST 2020


john.brawn added a comment.

This causes a lot of test failures in llvm/unittests/Support/VirtualFileSystemTest.cpp. A lot of them use //root as a root directory, and e.g. looking at the MappedFiles test what's happening is:

- `//root/foo/bar/a` is added to the DummyFileSystem
- getFromYAMLString used on a YAML string that maps `//root/file1` to `//root/foo/bar/a`
- The `//root/foo/bar/a` is canonicalized to `/root/foo/bar/a`
- `O->status("//root/file1")` matches the `//root/file1` in the YAML, but the subsequent lookup tries to find `/root/foo/bar/a` which doesn't match the `//root/foo/bar/a` that was added to the DummyFileSystem so we get a "file not found" error


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74777/new/

https://reviews.llvm.org/D74777





More information about the llvm-commits mailing list