[PATCH] D74792: [SimplifyLibCalls][IRBuilder] Accept any IRBuilder in SimplifyLibCalls

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 19 04:26:21 PST 2020


nhaehnle added a comment.

That's a nice improvement. I do have one detail question.



================
Comment at: llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp:3109-3111
+      IRBuilderBase::InsertPointGuard Guard(Builder);
+      Builder.SetInsertPoint(SimplifiedCI);
+      if (Value *V = optimizeStringMemoryLibCall(SimplifiedCI, Builder)) {
----------------
The OperandBundlesGuard covers this point, where bundles where previously not applied as far as I can tell. Is that intended?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74792/new/

https://reviews.llvm.org/D74792





More information about the llvm-commits mailing list