[PATCH] D74773: [LLD][Debuginfo][NFC] create DWARFContext only once for the same object file.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 19 00:04:12 PST 2020


grimar added inline comments.


================
Comment at: lld/ELF/InputFiles.cpp:271
+      [&](Error Err) {
+        error(getName() + ": " + toString(std::move(Err)), true);
+      },
----------------
Lets also see what other LLD people think, but it does not feel to me that LLD should get something like "recoverable error" concept.
We already have warnings to report something not critical, so why not just report a warning in this case?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74773/new/

https://reviews.llvm.org/D74773





More information about the llvm-commits mailing list