[PATCH] D74768: [mlir] Support OptionalAttr inside a StructAttr

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 18 15:38:36 PST 2020


rriddle added inline comments.


================
Comment at: mlir/tools/mlir-tblgen/StructsGen.cpp:147
+    if (field.getType().isOptional()) {
+      os << llvm::formatv(getFieldInfoOptional, field.getName());
+    } else {
----------------
nit: remove trivial braces here and below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74768/new/

https://reviews.llvm.org/D74768





More information about the llvm-commits mailing list