[PATCH] D74306: [MIR][ARM] MachineOperand comments to print condition code names instead of constants

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 18 15:20:40 PST 2020


efriedma added subscribers: MatzeB, arsenm.
efriedma added a comment.

I can see two problems with `[]` comment delimiters:

1. `]` is used somewhat frequently in target-specific assembly syntax, so it might end up overlapping with stuff some target wants to print.  Maybe not that likely in practice.
2. It isn't obvious that the contents of the `[]` is a comment.  Something like `/**/` would give instant recognition to people even if they're not really familiar with MIR syntax.

Otherwise looks fine.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74306/new/

https://reviews.llvm.org/D74306





More information about the llvm-commits mailing list