[PATCH] D74691: [Attributor] add some pattern to containsCycle

[omar ahmed via Phabricator via llvm-commits]

omarahmed added a comment.

@baziotis  I have made exactly the impl like the last comment but it fails in 7 tests now , I have debugged in it with willreturn.ll tests as it fails and in the first test

  define void @only_return() #0 {
      ret void
  }

in this test with the impl it hit the condition with if Loop is null and return true like this part

> First of all, try to get L. If you don't have a loop (so, L is null) then this
>  SCC is not a loop so return true immediately.

so it doesn't get the will return attribute and that makes the test fails
shouldn't this condition continue and not return true as what I understand from this behavior is that it gets a single node as a SCC and doesn't find a loop in it isn't that a willreturn behavior as it doesn't contain a loop  ?
could we use SCCI.hasLoop() function before checking on getLoopFor() as it checks for SCC with single BB and with no loops ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74691/new/

https://reviews.llvm.org/D74691