[PATCH] D73342: Fix EarlyCSE to intersect aliasing metadata.

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/EarlyCSE.cpp:1099
+
+          if (auto OpInst = dyn_cast<Instruction>(Op)) {
+            combineMetadataForCSE(OpInst, Inst, true);
----------------
No { } around single statement if.


================
Comment at: llvm/lib/Transforms/Scalar/EarlyCSE.cpp:1100
+          if (auto OpInst = dyn_cast<Instruction>(Op)) {
+            combineMetadataForCSE(OpInst, Inst, true);
+          }
----------------
Why is DoesKMove true here? OpInst dominated Inst in the original IR, no?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73342/new/

https://reviews.llvm.org/D73342