[PATCH] D74613: [DebugInfo] Fix printing CIE offsets in EH FDEs.

Tue Feb 18 06:05:01 PST 2020

ikudrin marked an inline comment as done.
ikudrin added inline comments.

================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFDebugFrame.h:226
 public:
   // Each FDE has a CIE it's "linked to". Our FDE contains is constructed with
   // an offset to the CIE (provided by parsing the FDE header). The CIE itself
----------------
ikudrin wrote:
> jhenderson wrote:
> > Could you fix the second sentence of this comment (possibly as a separate commit). I think the "contains" needs deleting.
> > 
> > It might also be worth saying whether the offset is relative or from the start of the section.
> The comment is about the laziness of acquiring the CIE, but it looks like that was never true, even from the [[ https://reviews.llvm.org/rGfd08bc195b36b2262f9ee4b283eef44b0520ebed | beginning ]]. I guess it is better to remove this comment altogether.
I've added D74761 to remove the comment. What do you think?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74613/new/

https://reviews.llvm.org/D74613