[PATCH] D72713: [ARM][LowOverheadLoops] Check loop liveouts

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 18 07:30:26 PST 2020


SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:537
+  // instruction needs to be predicated, so check this here.
+  for (auto *MI : LiveMIs) {
+    int PIdx = llvm::findFirstVPTPredOperandIdx(*MI);
----------------
SjoerdMeijer wrote:
> Looks like we don't need this loop (and insert instructions in `LiveMIs`), the `findFirstVPTPredOperandIdx()` can be done directly in the loop above.
Ok, ignore this one; I understand this is a prep step for a follow up patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72713/new/

https://reviews.llvm.org/D72713





More information about the llvm-commits mailing list