[PATCH] D74768: [mlir] Support OptionalAttr inside a StructAttr

Tamas Berghammer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 18 07:02:31 PST 2020


tberghammer created this revision.
tberghammer added a reviewer: rsuderman.
Herald added subscribers: Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, burmako, jpienaar, rriddle, mehdi_amini.
Herald added a project: LLVM.

Previously many of the generated methods were crashing when the user
tried to pass a nullptr (translating to a null attribute) into optional
fields.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D74768

Files:
  mlir/tools/mlir-tblgen/StructsGen.cpp
  mlir/unittests/TableGen/StructsGenTest.cpp
  mlir/unittests/TableGen/structs.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74768.245156.patch
Type: text/x-patch
Size: 3686 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200218/c1715fe1/attachment.bin>


More information about the llvm-commits mailing list